Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: follow-up fixes for detached pydantic.BaseModel schemas #3829

Merged
merged 20 commits into from
Oct 11, 2023
Merged

fix: follow-up fixes for detached pydantic.BaseModel schemas #3829

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e297605
fix: add missing `abc.ABC` in `RemoteSchema`
alvarobartt Sep 26, 2023
519b800
fix: add missing `abc.ABC` in `FieldSchema` and `QuestionSchema`
alvarobartt Sep 26, 2023
160c3d4
fix: pop `id` in `DatasetConfig.from_yaml`
alvarobartt Sep 26, 2023
5a46584
feat: extend `generate_pydantic_schema` type-hints
alvarobartt Sep 26, 2023
871b2da
refactor: `__init__` validation to `FeedbackDataset`
alvarobartt Sep 26, 2023
2cce820
feat: define `ResponseStatusFilter`
alvarobartt Sep 28, 2023
b45a425
fix: use `property` + `abstractmethod` instead of `abstractproperty`
alvarobartt Oct 10, 2023
f881cee
refactor: move `ResponseStatus` and `ResponseStatusFilter` to `enums.py`
alvarobartt Oct 10, 2023
ba1268e
revert: `Enum` cannot be extended
alvarobartt Oct 10, 2023
8b74e16
fix: `AllowedQuestionTypes` import
alvarobartt Oct 10, 2023
0270ac6
Merge branch 'develop' of github.com:argilla-io/argilla into fix/afte…
alvarobartt Oct 10, 2023
af57f3a
fix: `push_to_argilla` to parse `Remote{Field,Question}`
alvarobartt Oct 10, 2023
8d10963
fix: `from_huggingface` fully backwards compatible
alvarobartt Oct 10, 2023
d1d4098
test(unit): ensure back comp with `argilla.cfg`
alvarobartt Oct 11, 2023
3cca5cc
fix(style): `DatasetConfig.from_yaml` naming
alvarobartt Oct 11, 2023
f5bd67e
test(unit): ensure back comp with `argilla.yaml`
alvarobartt Oct 11, 2023
9534c81
docs: update `CHANGELOG.md`
alvarobartt Oct 11, 2023
bfaabeb
fix: `DeprecatedDatasetConfig.from_json` check `settings`
alvarobartt Oct 11, 2023
d337e38
revert: move `__init__` validation to `FeedbackDatasetBase`
alvarobartt Oct 11, 2023
5b43da3
fix(test): `ResponseStatusFilter` outdated import
alvarobartt Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: add missing abc.ABC in RemoteSchema
  • Loading branch information
@alvarobartt
alvarobartt committed Sep 26, 2023
commit e297605d9267e3f8cf9495d8cb378020707577ad
4 changes: 2 additions & 2 deletions src/argilla/client/feedback/schemas/remote/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from abc import abstractmethod
from abc import ABC, abstractmethod
from typing import Optional, Type
from uuid import UUID

import httpx
from pydantic import BaseModel


class RemoteSchema(BaseModel):
class RemoteSchema(BaseModel, ABC):
id: Optional[UUID] = None
client: Optional[httpx.Client] = None

Expand Down