-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add list
classmethod to FeedbackDataset
via ArgillaMixin
#3619
Conversation
list
classmethod to FeedbackDataset
via ArgillaMixin
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3619 +/- ##
===========================================
- Coverage 90.59% 90.59% -0.01%
===========================================
Files 260 260
Lines 13700 13711 +11
===========================================
+ Hits 12412 12421 +9
- Misses 1288 1290 +2
☔ View full report in Codecov by Sentry. |
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3619-ki24f765kq-no.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think that we can filter the datasets in the client until we add the filter in the API, wdyt?
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
for more information, see https://pre-commit.ci
Description
This PR adds the class method
list
inArgillaMixin
, also renamed fromArgillaToFromMixin
. This way, users can callFeedbackDataset.list()
to list all theFeedbackDataset
datasets in Argilla.Additionally,
list
includes the argworkspace
so that users can also specify theworkspace
that they want to list from, in case those are assigned to more than one workspace.Closes #3413
Mentioned #3521 #3591
Type of change
How Has This Been Tested
FeedbackDataset.list
(producing a list ofRemoteFeedbackDataset
)Checklist