Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more value validations for rating questions #3451

Closed
frascuchon opened this issue Jul 25, 2023 · 0 comments · Fixed by #3452
Closed

Add more value validations for rating questions #3451

frascuchon opened this issue Jul 25, 2023 · 0 comments · Fixed by #3452
Assignees
@frascuchon @gabrielmbmb @alvarobartt
Milestone
v1.14.0

Comments

@frascuchon
Copy link
Member

frascuchon commented Jul 25, 2023 •
edited
Loading

By limiting the rating questions configuration, the shortcut flow can be drastically simplified.

  • Limit the number of values for the rating questions to 10
  • Define lower and upper limits to 1 <= x <= 10

Refs: https://github.com/argilla-io/Team/issues/114
@frascuchon frascuchon changed the title Limit the number of choices for rating questions Add more value validations for rating questions Jul 25, 2023
@frascuchon frascuchon added this to the v1.14.0 milestone Jul 25, 2023
@frascuchon frascuchon linked a pull request Jul 25, 2023 that will close this issue
feat: add more value validations for rating questions #3452
Merged
9 tasks
@frascuchon frascuchon mentioned this issue Jul 25, 2023
Merged
9 tasks
frascuchon added a commit that referenced this issue Jul 26, 2023
@frascuchon @tomaarsen
@pre-commit-ci @alvarobartt
feat: add more value validations for rating questions (#3452)
af60012 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

This PR introduces new validations for rating questions to limit use
cases.

- Only unique values in the range [1, 10] are allowed

Closes #3451 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

Playing around locally creating a dataset with wrong bound values for
the rating question:

<img width="1589" alt="Screenshot 2023-07-25 at 18 46 46"
src="https://github.com/argilla-io/argilla/assets/2518789/ab1fc16e-bebc-4ebe-9c08-cfe5b71ce00d">

**Checklist**

- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Tom Aarsen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alvaro Bartolome <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

@gabrielmbmb gabrielmbmb

@alvarobartt alvarobartt

Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

feat: add more value validations for rating questions argilla-io/argilla
3 participants
@frascuchon @gabrielmbmb @alvarobartt