-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSOC 2020: [Preferences] Button problem in Preferences #9185 requires translation #9947
base: master
Are you sure you want to change the base?
Conversation
At first glance, your changes look good to me, though I have not tested them. I have no strong opinion on the UI changes themselves (so I'll leave those to others to review), but I do have some suggestions for your commit messages:
As I previously said elsewhere: If you make these changes, please do a force push to this same branch to update this PR, rather than creating a new PR. |
Thank you for such descriptive reply. Another PR is not closed. It is an alternative solution which does not require translation, but is less descriptive. I am using an existing sentence that was already translated. I did this way, so someone can make a decision about how much effort should be done and which change is preferred. "What changes when you add this property in the form file?"
|
|
[Preferences] Button problem in Preferences #9185 requires translation
This pull request is more descriptive than #9945, but it requires translation in resource files.
Not sure about necessary workflows.
Tested Windows, Linux.
Tool Tip still pops up for different languages, but on English. I can help with Russian/Ukrainian if needed.