Respect changes to INITIAL_WINDOW_SIZE in outbound buffer. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When the remote peer changes SETTINGS_INITIAL_WINDOW_SIZE, this change affects the flow control window sizes of all existing streams (as though they were created with this new initial window size). We should respect those flow control changes. Modifications: - Propagated changes in SETTINGS_INITIAL_WINDOW_SIZE. - Made NIOHTTP2ConnectionStateChange internal. - Added support for changing initial window size. Result: SETTINGS frames that change initial window size now work properly.
Lukasa
force-pushed
the
cb-inbound-flow-control-change-via-settings
branch
from
3bb208c
to
1679b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the remote peer changes SETTINGS_INITIAL_WINDOW_SIZE, this change
affects the flow control window sizes of all existing streams (as though
they were created with this new initial window size). We should respect
those flow control changes.
Modifications:
Result:
SETTINGS frames that change initial window size now work properly.