New HTTP/2 currency types. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
requested changes
Feb 25, 2019
Sources/NIOHTTP2/HTTP2Frame.swift
Outdated
| /// A single HTTP/2 frame, along with the state change it triggered in the state machine. | ||
| public struct HTTP2FrameWithMetadata { | ||
| /// The received HTTP/2 frame. | ||
| var frame: HTTP2Frame |
Sources/NIOHTTP2/HTTP2Frame.swift
Outdated
| /// the state change triggered by parsing this frame. | ||
| public struct HTTP2FrameWithMetadataRequest { | ||
| /// The HTTP/2 frame to send. | ||
| var frame: HTTP2Frame |
Lukasa
force-pushed
the
cb-new-data-flow
branch
2 times, most recently
from
0b7245e
to
e2f085a
Compare
Motivation: As discussed in our HTTP/2 types manifesto, it is helpful to run more metadata through the HTTP/2 pipeline. This makes it easier to write ChannelHandlers that fully participate in the HTTP/2 state machine while avoiding needing to too tightly couple the handlers. Modifications: - Added new HTTP/2 pipeline data types. - Removed HTTP2Frame.FrameFlags, moved flags into relevant payloads. Result: Right now, not much. All tests pass with new payload types. The full data path rewrite will follow in a separate patch, as this one is large enough.
Lukasa
force-pushed
the
cb-new-data-flow
branch
from
e2f085a
to
36378a3
Compare
|
Ok, ready for re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As discussed in our HTTP/2 types manifesto, it is helpful to run more
metadata through the HTTP/2 pipeline. This makes it easier to write
ChannelHandlers that fully participate in the HTTP/2 state machine
while avoiding needing to too tightly couple the handlers.
Modifications:
Result:
Right now, not much. All tests pass with new payload types. The full
data path rewrite will follow in a separate patch, as this one is large
enough.