Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new HTTP/2 pipeline configurator. #42

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

Lukasa
Copy link
Contributor

@Lukasa Lukasa commented Feb 21, 2019

Motivation:

Rather than rely on users to get a bunch of stuff right when configuring
their HTTP/2 pipelines, it's helpful to insert the handlers in the right
order in a helper function.

Modifications:

Provide a helper configurator that inserts handlers correctly.

Result:

Easier to configure HTTP/2 pipelines.

@Lukasa Lukasa requested a review from weissi February 21, 2019 17:43
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

Motivation:

Rather than rely on users to get a bunch of stuff right when configuring
their HTTP/2 pipelines, it's helpful to insert the handlers in the right
order in a helper function.

Modifications:

Provide a helper configurator that inserts handlers correctly.

Result:

Easier to configure HTTP/2 pipelines.
@Lukasa Lukasa merged commit 9492473 into apple:master Feb 22, 2019
@Lukasa Lukasa deleted the cb-pipeline-configurator branch February 22, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants