chore: include devicectl in IOSDeploy object #2352
Conversation
| const devicectl = new Devicectl(this.opts.udid, this.log); | ||
| const fileNames = await devicectl.listFiles(DOMAIN_TYPE, DOMAIN_IDENTIFIER, { | ||
| // @ts-expect-error - do not assign arbitrary properties to `this.opts` | ||
| const device = this.opts.device; |
There was a problem hiding this comment.
it makes sense to explicitly provide the type of device, so typescript could verify further typechecks. Same note for other calls
There was a problem hiding this comment.
Yea, i wondered if it could. I need to learn more to add them as another pr. Initially I thought something like the below in driver.js, but maybe it was wrong.
/**
* @typedef {import('@appium/types').DriverOpts<XCUITestDriverConstraints>} XCUITestDriverOpts
* @property {import('./devicectl')Devicectl} device
*/
There was a problem hiding this comment.
I was thinking about having device property attached directly to the driver, like
get device () {
return this.opts.device;
}
With proper typehints this should work nicely. Maybe I will take care about it later myself after your changes are done
|
It would probably make sense to bump the major WDA version when we are going to use devicectl attached to the |
|
hm https://github.com/appium/appium-xcuitest-driver/actions/runs/8413083261/job/23034781606 |
* chore: include devicectl in IOSDeploy object * add ignore * define once to reduce ignore * define once to reduce ignore * mofidy log
|
🎉 This PR is included in version 7.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
the command itself failed but below example was this pr's test. The
lib/commands/memory.js's instance called the devicectl command properly