fix: Properly handle WDA session startup errors #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mykola-mokhnach
commented
Feb 23, 2024
mykola-mokhnach
commented
- It does not make sense to uninstall WDA when session startup fails, because that means WDA has actually started successfully
- We must short-circuit (e.g. no more reties) if the session startup times out
- Hardcoded repeats for WDA session startup are useless. They only prolong the time to fail.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
## [7.1.2](v7.1.1...v7.1.2) (2024-02-23) ### Bug Fixes * Properly handle WDA session startup errors ([#2331](#2331)) ([f4ca5ee](f4ca5ee))
|
🎉 This PR is included in version 7.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.