fix: build error #2356
Merged
fix: build error #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2024
| @@ -36,15 +36,22 @@ async function createSim(caps) { | |||
| if (!deviceName) { | |||
| let deviceNames = 'none'; | |||
| try { | |||
| deviceNames = await simctl | |||
| .getDevices(platformVersion, platform) | |||
| deviceNames = (await simctl | |||
There was a problem hiding this comment.
this is a nice catch, which would be hardly possible without proper typing.
I am currently working on appium-ios-simulator lib changes, so it could also be properly typed
lib/simulator-management.js
Outdated
|
|
||
| if (!platformVersion) { | ||
| throw new Error( | ||
| `'platformVersion' is required.` |
There was a problem hiding this comment.
there is no need to split a short error message into multiple lines
mykola-mokhnach
approved these changes
Mar 25, 2024
|
🎉 This PR is included in version 7.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/appium/appium-xcuitest-driver/actions/runs/8413083261/job/23034781606