[BUILD][HOTFIX] Add -DskipTests property to reduce build time #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Looks great to me @minahlee lets |
!
|
Merge if there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2016
### What is this PR for?
In `dev/publish_release.sh` there are two mvn build. Second build fails with follow error:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (start-zeppelin) on project zeppelin-server: An Ant BuildException has occured: The directory /private/tmp/zeppelin-release/zeppelin/zeppelin-server/${zeppelin.daemon.package.base} does not exist
[ERROR] around Ant part ...<exec spawn="true" dir="${zeppelin.daemon.package.base}" executable="./zeppelin-daemon.sh">... 4:94 in /private/tmp/zeppelin-release/zeppelin/zeppelin-server/target/antrun/build-main.xml
```
This PR skip tests to fix this issue as hotfix. In addition, it will reduce build time
### What type of PR is it?
Build
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Mina Lee <[email protected]>
Closes #1321 from minahlee/build_skipTests and squashes the following commits:
c1aa845 [Mina Lee] Add -DskipTests property to reduce build time
(cherry picked from commit 74c9756)
Signed-off-by: Mina Lee <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Oct 12, 2016
…n repository ### What is this PR for? While removing duplication of specifying build profile in #1321, build profile has been changed from `-Ppublish-distr` to `-Pbuild-distr`. We need to restore this change and use `-Ppublish-distr` profile to publish `*.javadoc.jar ` and `*.sources.jar`. ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <[email protected]> Closes #1506 from minahlee/build_profile and squashes the following commits: b84b371 [Mina Lee] Change build profile for distributing artifact to maven repository
asfgit
pushed a commit
that referenced
this pull request
Oct 12, 2016
…n repository ### What is this PR for? While removing duplication of specifying build profile in #1321, build profile has been changed from `-Ppublish-distr` to `-Pbuild-distr`. We need to restore this change and use `-Ppublish-distr` profile to publish `*.javadoc.jar ` and `*.sources.jar`. ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <[email protected]> Closes #1506 from minahlee/build_profile and squashes the following commits: b84b371 [Mina Lee] Change build profile for distributing artifact to maven repository (cherry picked from commit 22bd851) Signed-off-by: Mina Lee <[email protected]>
pedrozatta
pushed a commit
to pedrozatta/zeppelin
that referenced
this pull request
Oct 27, 2016
…n repository ### What is this PR for? While removing duplication of specifying build profile in apache#1321, build profile has been changed from `-Ppublish-distr` to `-Pbuild-distr`. We need to restore this change and use `-Ppublish-distr` profile to publish `*.javadoc.jar ` and `*.sources.jar`. ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <[email protected]> Closes apache#1506 from minahlee/build_profile and squashes the following commits: b84b371 [Mina Lee] Change build profile for distributing artifact to maven repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In
dev/publish_release.shthere are two mvn build. Second build fails with follow error:This PR skip tests to fix this issue as hotfix. In addition, it will reduce build time
What type of PR is it?
Build
Questions: