Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display no data alert when async result has zero rows #2055

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Display no data alert when async result has zero rows #2055

merged 1 commit into from
Jan 27, 2017

Conversation

vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Jan 26, 2017 •
edited
Loading

Before:

  • when query was run asynchronously and result returned with zero rows, fetch result button is always displayed, clicking on it doesn't do anything, which causes confusion

After:

  • if query already returned with empty data, display 'no data' alert

Tested in staging:
screen shot 2017-01-27 at 11 06 33 am

@mistercrunch

@bkyryliuk
Copy link
Member

LGTM, make sure it works on staging

@vera-liu vera-liu mentioned this pull request Jan 26, 2017
Closed
@vera-liu vera-liu merged commit 4a8cd04 into apache:master Jan 27, 2017
@vera-liu vera-liu mentioned this pull request Jan 27, 2017
Merged
SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
@vera-liu
Display no data when async result has zero rows (apache#2055)
88c4fb5
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.16.0 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vera-liu @bkyryliuk @mistercrunch