[explorev2] Make chart container more responsive #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Leave chart empty when theres error **Make all boolean fields auto-query chart when changed
vera-liu
changed the title
mistercrunch
reviewed
Dec 1, 2016
| style={{ 'overflow-x': 'scroll' }} | ||
| />) | ||
| } | ||
| {this.renderChart(this.props.alert, this.props.isChartLoading)} |
There was a problem hiding this comment.
maybe I'm missing something but you shouldn't have to pass props as they'll be in scope in the function
| }); | ||
| const refreshChart = Object.keys(nextProps.form_data).some((field) => ( | ||
| nextProps.form_data[field] !== this.props.form_data[field] | ||
| && (typeof nextProps.form_data[field] === 'boolean' |
There was a problem hiding this comment.
Does this mean you assume that all boolean fields should act like an autoQueryFields? It may not be the case. I think you probably want to add these fields in the autoQueryFields array instead.
|
Nice, LGTM. eventually we should have a way to tell the user that a field is an |
|
Maybe at some point we could reorganize Control Panel for each viz_type so that 'Chart Options' are grouped together as one section and every field in it is auto-query |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
the old chart stays in chart container when there's error drawing new chart
Done:
**Leave chart empty when theres error
**Make all boolean fields auto-query chart when changed
needs-review @ascott