Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48813][SQL][DOCS] Add a notice that mariadb protocol does not apply when the database is MariaDB #47220

Closed
wants to merge 2 commits into from

Conversation

wayneguow
Copy link
Contributor

@wayneguow wayneguow commented Jul 4, 2024

What changes were proposed in this pull request?

This PR aims to add a notice that mariadb protocol does not apply when the database is MariaDB in sql-data-sources-jdbc.md.

Why are the changes needed?

MariaDBDialect is not implemented currently. If the user uses the jdbc:mariadb protocol, an error will occur,as described in https://issues.apache.org/jira/browse/SPARK-25013. It's better to add a notice that when users get an error, they can get help from the documentation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

@github-actions github-actions bot added the DOCS label Jul 4, 2024
@wayneguow
Copy link
Contributor Author

Gentle ping @HyukjinKwon, currently I am just adding a notice in the docs to give some help for users. Do we need to further throw an exception directly for the jdbc:mariadb protocol in the JdbcDialects.get method? But it's a little bit hardcode. WDYT?

@yaooqinn
Copy link
Member

yaooqinn commented Jul 5, 2024

Since we don't have MariaDBDialect to support jdbc:mariadb internally, it belongs to third-party implementations. We don't need this for end-users

@wayneguow
Copy link
Contributor Author

@yaooqinn Thank you for reviewing mariadb related PRs, I think what you said makes sense, so I will close these.

@wayneguow wayneguow closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants