[SPARK-48800][CONNECT][SS] Deflake ClientStreamingQuerySuite #47205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WweiL
changed the title
|
Thanks! Added @allisonwang-db |
|
Thanks! Merging to master. |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
### What changes were proposed in this pull request? The listener test in `ClientStreamingQuerySuite` is flaky. For client side listeners, the terminated events might take a while before arriving to the client. This test is currently flaky, example: https://github.com/anishshri-db/spark/actions/runs/9785389228/job/27018350836 This PR tries to deflake it by waiting for a longer time. ### Why are the changes needed? Deflake test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47205 from WweiL/deflake-listener-client-scala. Authored-by: Wei Liu <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? The listener test in `ClientStreamingQuerySuite` is flaky. For client side listeners, the terminated events might take a while before arriving to the client. This test is currently flaky, example: https://github.com/anishshri-db/spark/actions/runs/9785389228/job/27018350836 This PR tries to deflake it by waiting for a longer time. ### Why are the changes needed? Deflake test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47205 from WweiL/deflake-listener-client-scala. Authored-by: Wei Liu <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The listener test in
ClientStreamingQuerySuiteis flaky.For client side listeners, the terminated events might take a while before arriving to the client. This test is currently flaky, example: https://github.com/anishshri-db/spark/actions/runs/9785389228/job/27018350836
This PR tries to deflake it by waiting for a longer time.
Why are the changes needed?
Deflake test
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test only change
Was this patch authored or co-authored using generative AI tooling?
No