[SPARK-48793][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. DROP|RENAME COLUMN[S] ... tests
#47199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N | COLUMNS) ...` tests
panbingkun
changed the title
ALTER TABLE .. DROP (COLUMN | COLUMNS) ... testsALTER TABLE .. DROP|RENAME COLUMN[S] ... tests
…` COLUMN[S] ... tests
|
cc @cloud-fan |
cloud-fan
approved these changes
Jul 11, 2024
|
thanks, merging to master! |
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
…NAME` COLUMN ...` tests ### What changes were proposed in this pull request? The pr aims to: - Move parser tests from `o.a.s.s.c.p.DDLParserSuite` and `o.a.s.s.c.p.ErrorParserSuite` to `AlterTableRenameColumnParserSuite` & `AlterTableDropColumnParserSuite` - Add a test for DSv2 ALTER TABLE .. `DROP|RENAME` to `v2.AlterTableDropColumnSuite` & `v2.AlterTableRenameColumnSuite` (This PR includes the unification of two commands: `DROP COLUMN` & `RENAME COLUMN`) ### Why are the changes needed? - To improve test coverage. - Align with other similar tests, eg: AlterTableRename* ### Does this PR introduce _any_ user-facing change? No, only tests. ### How was this patch tested? - Add new UT - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47199 from panbingkun/alter_table_drop_column. Authored-by: panbingkun <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to:
o.a.s.s.c.p.DDLParserSuiteando.a.s.s.c.p.ErrorParserSuitetoAlterTableRenameColumnParserSuite&AlterTableDropColumnParserSuiteDROP|RENAMEtov2.AlterTableDropColumnSuite&v2.AlterTableRenameColumnSuite(This PR includes the unification of two commands:
DROP COLUMN&RENAME COLUMN)Why are the changes needed?
Does this PR introduce any user-facing change?
No, only tests.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.