[SPARK-48775][SQL][STS] Replace SQLContext with SparkSession in STS #47176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also cc @dongjoon-hyun |
LuciferYang
reviewed
Jul 5, 2024
...-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
Outdated
Show resolved
Hide resolved
LuciferYang
reviewed
Jul 5, 2024
| * @param exitOnError Whether to exit the JVM if HiveThriftServer2 fails to initialize. When true, | ||
| * the call logs the error and exits the JVM with exit code -1. When false, the | ||
| * call throws an exception instead. | ||
| */ | ||
| @Since("4.0.0") | ||
| @DeveloperApi | ||
| def startWithContext(sqlContext: SQLContext, exitOnError: Boolean): HiveThriftServer2 = { | ||
| def startWithSparkSession( |
There was a problem hiding this comment.
It seems that aside from the unreleased API added in 4.0, this pr has not caused any breaking changes.
If so, the changes is fine to me. WDYT? @HyukjinKwon @yaooqinn
There was a problem hiding this comment.
Yes, it's okay to change . Maybe, this is the last chance if we want to change this.
| @@ -82,10 +84,11 @@ object HiveThriftServer2 extends Logging { | |||
| * | |||
| * @param sqlContext SQLContext to use for the server | |||
| */ | |||
| @deprecated("use startWithSparkSession instead", since = "4.0.0") | |||
…/thriftserver/SparkSQLCLIService.scala Co-authored-by: YangJie <[email protected]>
dongjoon-hyun
approved these changes
Jul 11, 2024
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? Remove the exposed `SQLContext` which was added in SPARK-46575. And migrate STS internal used `SQLContext` to `SparkSession`. ### Why are the changes needed? `SQLContext` is not recommended since Spark 2.0, the suggested replacement is `SparkSession`. We should avoid exposing the deprecated class to Developer API in new versions. ### Does this PR introduce _any_ user-facing change? No. It touched the Developer API added in SPARK-46575, but is not released yet. ### How was this patch tested? Pass GHA, and `dev/mima` (not breaking changes involved) ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47176 from pan3793/SPARK-48775. Lead-authored-by: Cheng Pan <[email protected]> Co-authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Remove the exposed `SQLContext` which was added in SPARK-46575. And migrate STS internal used `SQLContext` to `SparkSession`. ### Why are the changes needed? `SQLContext` is not recommended since Spark 2.0, the suggested replacement is `SparkSession`. We should avoid exposing the deprecated class to Developer API in new versions. ### Does this PR introduce _any_ user-facing change? No. It touched the Developer API added in SPARK-46575, but is not released yet. ### How was this patch tested? Pass GHA, and `dev/mima` (not breaking changes involved) ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47176 from pan3793/SPARK-48775. Lead-authored-by: Cheng Pan <[email protected]> Co-authored-by: Cheng Pan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the exposed
SQLContextwhich was added in SPARK-46575. And migrate STS internal usedSQLContexttoSparkSession.Why are the changes needed?
SQLContextis not recommended since Spark 2.0, the suggested replacement isSparkSession. We should avoid exposing the deprecated class to Developer API in new versions.Does this PR introduce any user-facing change?
No. It touched the Developer API added in SPARK-46575, but is not released yet.
How was this patch tested?
Pass GHA, and
dev/mima(not breaking changes involved)Was this patch authored or co-authored using generative AI tooling?
No.