[SPARK-48773] Document config "spark.default.parallelism" by config builder framework #47171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
changed the title
yaooqinn
reviewed
Jul 2, 2024
| "For distributed shuffle operations like reduceByKey and join, the largest number of " + | ||
| "partitions in a parent RDD. For operations like parallelize with no parent RDDs, " + | ||
| "it depends on the cluster manager: Local mode: number of cores on the local machine " + | ||
| "Mesos fine grained mode: 8 Others: total number of cores on all executor nodes or 2, " + |
yaooqinn
reviewed
Jul 2, 2024
| @@ -42,6 +42,17 @@ package object config { | |||
| private[spark] val SPARK_TASK_PREFIX = "spark.task" | |||
| private[spark] val LISTENER_BUS_EVENT_QUEUE_PREFIX = "spark.scheduler.listenerbus.eventqueue" | |||
|
|
|||
| private[spark] val DEFAULT_PARALLELISM = | |||
There was a problem hiding this comment.
Can we replace all hardcoded ones with this？
There was a problem hiding this comment.
Done.
I also found PySpark side is using the same string. However I am not sure how PySpark generally deal with configs so leave PySpark side unchanged.
core/src/main/scala/org/apache/spark/internal/config/package.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: allisonwang-db <[email protected]>
yaooqinn
reviewed
Jul 3, 2024
Comment on lines
+51
to
+52
| "it depends on the cluster manager. For example in Local mode, it defaults to the " + | ||
| "number of cores on the local machine") |
There was a problem hiding this comment.
Since we now do not have fine-grained schedulers, both the local and others are using total number of cores?
There was a problem hiding this comment.
This is something I am not sure. @cloud-fan do you remember?
There was a problem hiding this comment.
I think so, but we don't need to expose such low-level details to end users.
cloud-fan
approved these changes
Jul 11, 2024
|
thanks, merging to master! |
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
…uilder framework ### What changes were proposed in this pull request? Document config "spark.default.parallelism". This is Spark used config but not documented by config builder framework. This config is already in spark website: https://spark.apache.org/docs/latest/configuration.html. ### Why are the changes needed? Document Spark's config. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? N/A Closes apache#47171 from amaliujia/document_spark_default_paramllel. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…uilder framework ### What changes were proposed in this pull request? Document config "spark.default.parallelism". This is Spark used config but not documented by config builder framework. This config is already in spark website: https://spark.apache.org/docs/latest/configuration.html. ### Why are the changes needed? Document Spark's config. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? N/A Closes apache#47171 from amaliujia/document_spark_default_paramllel. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Document config "spark.default.parallelism". This is Spark used config but not documented by config builder framework. This config is already in spark website: https://spark.apache.org/docs/latest/configuration.html.
Why are the changes needed?
Document Spark's config.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
N/A