Fix start() and shutdown() of DefaultMessagingProcessor #7838
Conversation
| @@ -124,6 +124,12 @@ public static DefaultMessagingProcessor createForClusterMode(RPCHook rpcHook) { | |||
|
|
|||
| protected void init() { | |||
| this.appendStartAndShutdown(this.serviceManager); | |||
| this.appendStartAndShutdown(producerProcessor); | |||
There was a problem hiding this comment.
It seems that it's not necessary to start processors because this issue is only related to receiptHandleManager.
There was a problem hiding this comment.
It seems that it's not necessary to start processors because this issue is only related to receiptHandleManager.
Indeed, this issue is only related to receiptHandleProcessor. But all these processors extend AbstractStartAndShutdown and there is no caller, which may be error-prone over time?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7838 +/- ##
==========================================
Coverage 42.95% 42.95%
- Complexity 9909 9914 +5
==========================================
Files 1190 1190
Lines 85984 86016 +32
Branches 11079 11079
==========================================
+ Hits 36932 36946 +14
- Misses 44472 44490 +18
Partials 4580 4580 ☔ View full report in Codecov by Sentry. |
|
any update? |
Which Issue(s) This PR Fixes
Fixes #7837
Brief Description
How Did You Test This Change?
UT