Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7540] Fix query offset of compaction topic #7541

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Nov 6, 2023

Which Issue(s) This PR Fixes

Fixes #7540

Brief Description

Check the cleanup policy of the topic when processing offset query request in message store.

@codecov-commenter
Copy link

Codecov Report

Merging #7541 (7501bb5) into develop (46962c2) will increase coverage by 0.29%.
Report is 1 commits behind head on develop.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop    #7541      +/-   ##
=============================================
+ Coverage      42.97%   43.26%   +0.29%     
- Complexity      9677     9738      +61     
=============================================
  Files           1158     1158              
  Lines          83987    84020      +33     
  Branches       10917    10923       +6     
=============================================
+ Hits           36093    36353     +260     
+ Misses         43399    43146     -253     
- Partials        4495     4521      +26     
Files Coverage Δ
...ocketmq/broker/processor/SendMessageProcessor.java 37.13% <100.00%> (+0.84%) ⬆️
...rocketmq/common/message/MessageExtBrokerInner.java 28.57% <100.00%> (-27.43%) ⬇️
...pache/rocketmq/store/kv/CompactionPositionMgr.java 83.33% <100.00%> (ø)
...in/java/org/apache/rocketmq/common/KeyBuilder.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/common/utils/MessageUtils.java 61.11% <88.00%> (+61.11%) ⬆️
...org/apache/rocketmq/store/DefaultMessageStore.java 46.85% <75.00%> (+0.21%) ⬆️
.../org/apache/rocketmq/store/kv/CompactionStore.java 49.13% <64.28%> (+17.40%) ⬆️

... and 38 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@redlsz
Copy link
Contributor Author

redlsz commented Nov 6, 2023

@ltamber PTAL

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan
Copy link
Contributor

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Earlier messages in compaction topic cannot be consumed
6 participants