Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #950] support tls connection #951

Merged
merged 3 commits into from
Nov 6, 2023
Merged

[ISSUE #950] support tls connection #951

merged 3 commits into from
Nov 6, 2023

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Oct 22, 2022

What is the purpose of the change

support tls connection

Brief changelog

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #951 (924b85d) into master (50596e6) will decrease coverage by 0.01%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   23.44%   23.42%   -0.02%     
==========================================
  Files          52       52              
  Lines        7230     7243      +13     
==========================================
+ Hits         1695     1697       +2     
- Misses       5303     5312       +9     
- Partials      232      234       +2     
Impacted Files Coverage Δ
consumer/option.go 19.35% <0.00%> (-0.48%) ⬇️
internal/remote/remote_client.go 51.53% <ø> (ø)
producer/option.go 36.92% <0.00%> (-1.79%) ⬇️
internal/remote/tcp_conn.go 59.25% <37.50%> (-10.75%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

var err error
if config.UseTls {
conn, err = tls.DialWithDialer(&d, "tcp", addr, &tls.Config{
InsecureSkipVerify: true,

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High

InsecureSkipVerify should not be used in production code.
@ShannonDing ShannonDing linked an issue Nov 3, 2022 that may be closed by this pull request
@yuz10 yuz10 merged commit c9e197c into apache:master Nov 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support tls connection
3 participants