Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use golangci to improve code quality #88

Closed
xujianhai666 opened this issue Jul 3, 2019 · 0 comments
Closed

use golangci to improve code quality #88

xujianhai666 opened this issue Jul 3, 2019 · 0 comments

Comments

@xujianhai666
Copy link
Member

FEATURE REQUEST

  1. Please describe the feature you are requesting.
    I found that the code in native is so terrible to maintain, maybe author of client is not deeply familar with golang, so in order to improve code quality and pr quality, I think it is time to introduce golangci tool. more info about golangci: https://github.com/golangci/golangci-lint

  2. Provide any additional detail on your proposed use case for this feature.

  • avoid race case
  • useless code
  • more concise impl
  • field arrangement in struct for less byte
  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have).
    nice-to-have

  2. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Jul 3, 2019
zongtanghu pushed a commit that referenced this issue Jul 4, 2019
* fix address for issue

* use golangci fix goalng usage problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant