Update install-mxnet-osx-python.sh

[srochel]

Fixed handling of MXNET_TAG. If not set latest from master will be cloned to local directory. If a tag is specified, that tag will be used to clone the repository.

Tested with
MXNET_TAG="1.0.0.rc0" and MXNET_TAG not set in local environment

Description

Fixed handling of MXNET_TAG. If not set latest from master will be cloned to local directory. If a tag is specified, that tag will be used to clone the repository.

Checklist

Essentials

• [y] Passed code style checking (make lint)
• [y] Changes are complete (i.e. I finished coding on this PR)
• [n] All changes have test coverage
• [n] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
• [n] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

• [n] Feature1, tests, (and when applicable, API doc)
• [n] Feature2, tests, (and when applicable, API doc)

Comments

• change does not include check if tag in repo exists, can be further enhancement.
  I will work with Aaron to update documentation.

[aaronmarkham]

I see a couple of minor things that could improve usability and those are commented in the specific lines.
Outside of this, there seems to be a problem with the installation in two parts, the function that returns the version may be misreporting, and when running the installation twice in the same environment, the first version remains active.

This line states the version installed at the end of the script:
https://github.com/srochel/incubator-mxnet/blob/44813dd69fd6b3e7c9b98b56a55bced7f955fbdd/setup-utils/install-mxnet-osx-python.sh#L455

My results:
The results at the end (see just below) are unexpected since the version should be master with no tag used, or whatever the last build id was, right (not 0.12.1)?

SUCCESS: MXNet test passed
SUCCESS: MXNet is successfully installed and works fine!
SUCCESS: MXNet Version is: 0.12.1
END: Test MXNet

Using your example tag, this is the return at the end, which is truncated. We lost the rc0 part.

SUCCESS: MXNet test passed
SUCCESS: MXNet is successfully installed and works fine!
SUCCESS: MXNet Version is: 1.0.0
END: Test MXNet

Then when running that same version check manually I get the older version:
(mxnet3.6) 8c8590217d26:setup-utils markhama$ echo "import mxnet as mx; print(mx.version)" | python
0.12.1

Edit: it seems that version call seems like it is misreporting because of the context switch, but either way I think it might be better to change that line 455 to read:

git describe --tags

This way you get the full representation of whatever tag was used.

[aaronmarkham]

It tells you what version it is about to install without a y/n prompt, and I think it would be good to include that, so users now seeing that they can use an env var to switch versions they won’t have to break out of the script manually to do so (and that’s if they even notice it). Here's an example prompt.

[aaronmarkham]

Can you provide the specific command example like export MXNET_TAG=”1.0.0.rc0”.

[piiswrong]

@srochel Any updates?