Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-13841: removed jackson dependencies from SolrJ and provided a mapping to our annotation #992

Merged
merged 9 commits into from
Nov 4, 2019
Merged

SOLR-13841: removed jackson dependencies from SolrJ and provided a mapping to our annotation #992

merged 9 commits into from
Nov 4, 2019

Conversation

noblepaul
Copy link
Contributor

No description provided.

dsmiley
dsmiley requested changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good Noble. Mostly just needs some javadocs and lets discuss some renames.

solr/core/src/java/org/apache/solr/util/SolrPropertyAnnotationInspector.java Outdated Show resolved Hide resolved
solr/core/src/test/org/apache/solr/util/TestSolrJacksonAnnotation.java Show resolved Hide resolved
solr/solrj/src/java/org/apache/solr/common/annotation/Property.java Outdated Show resolved Hide resolved
solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaCreator.java Show resolved Hide resolved
@noblepaul noblepaul merged commit b5f5b0f into master Nov 4, 2019
@noblepaul noblepaul deleted the jira/solr13841 branch November 8, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsmiley dsmiley dsmiley requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noblepaul @dsmiley