-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-13822: Isolated Classloading from packages #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have more to review but I looked through 2/3rds of it.
I think the JIRA issue should enumerate the highlights here. For example this issue (as seen from the PR) isn't just the named classloading, it appears to introduce the very notion of a "Package" in the first place (huge deal). It also introduces a syntax for the named classloading for class= using a colon. This is a key thing. Also this adds an API; some endpoints -- a big deal. Needs to be summarized. New stuff is stored in Zookeeper --this should be summarized.
solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/Package.java
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/common/util/ReflectMapWriter.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/update/processor/UpdateRequestProcessorChain.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
Outdated
Show resolved
Hide resolved
…n packages are updated
Description
load plugins from packages
main features:
Checklist
Please review the following and check all that apply:
master
branch.ant precommit
and the appropriate test suite.