Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-13822: Isolated Classloading from packages #957

Merged
merged 20 commits into from
Oct 23, 2019
Merged

Conversation

noblepaul
Copy link
Contributor

@noblepaul noblepaul commented Oct 16, 2019

Description

load plugins from packages
main features:

  • A new file for packages definition (/packages.json) in ZK
  • Public APIs to edit/read the file
  • The APIs are registered at /api/cluster/package
  • Classes can be loaded from the package classloader using the <package_name>:<fully.qualified.ClassName> syntax

Checklist

Please review the following and check all that apply:

  • I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ant precommit and the appropriate test suite.
  • I have added tests for my changes.

Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more to review but I looked through 2/3rds of it.

I think the JIRA issue should enumerate the highlights here. For example this issue (as seen from the PR) isn't just the named classloading, it appears to introduce the very notion of a "Package" in the first place (huge deal). It also introduces a syntax for the named classloading for class= using a colon. This is a key thing. Also this adds an API; some endpoints -- a big deal. Needs to be summarized. New stuff is stored in Zookeeper --this should be summarized.

@noblepaul noblepaul merged commit 98f08d3 into master Oct 23, 2019
@noblepaul noblepaul deleted the jira/SOLR-13822 branch March 2, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants