Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9400: Tessellator might fail when several holes share the same vertex #1562

Merged
merged 4 commits into from
Jun 16, 2020

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jun 10, 2020

Make sure we do not build illegal polygons when merging holes that share a single vertex.

see https://issues.apache.org/jira/browse/LUCENE-9400

@iverase
Copy link
Contributor Author

iverase commented Jun 10, 2020

@nknize Can you have a look?

@iverase iverase changed the title LUCENE-9400: Tessallator might fail when several holes share the same vertex LUCENE-9400: Tessellator might fail when several holes share the same vertex Jun 10, 2020
Copy link
Member

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 75491ab into apache:master Jun 16, 2020
asfgit pushed a commit that referenced this pull request Jun 16, 2020
@iverase iverase deleted the LUCENE-9400 branch June 16, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants