SOLR-14525 For components loaded from packages SolrCoreAware, ResourceLoaderAware are not honored #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
reviewed
Jun 1, 2020
| @Override | ||
| public <T> boolean addToCoreAware(T obj) { | ||
| //do not do anything | ||
| //this class is |
There was a problem hiding this comment.
incomplete comment? Could use an explanation as to why. SolrCoreAware isn't handled here.
| if (obj instanceof ResourceLoaderAware) { | ||
| assertAwareCompatibility(ResourceLoaderAware.class, obj); | ||
| try { | ||
| ((ResourceLoaderAware) obj).inform(this); |
There was a problem hiding this comment.
Lets figure out why the base class doesn't just immediately call inform like this here. What test then fails? I've read an interesting JIRA issue: https://issues.apache.org/jira/browse/SOLR-8311 (lots of info there; I recommend reading all of it) It's been on my mind for some time now actually since when I was cleaning up SolrResourceLoader since this "live" wart seems like a hack.
There was a problem hiding this comment.
I think the order has to be
- create instance
init()SolrCoreAware.inform(),ResourceLoaderAware.inform()
I've made the relevant changes. Pls review
| @@ -117,6 +114,13 @@ protected void initNewInstance(PackageLoader.Package.Version newest) { | |||
| Object instance = SolrCore.createInstance(pluginInfo.className, | |||
| pluginMeta.clazz, pluginMeta.getCleanTag(), core, newest.getLoader()); | |||
| PluginBag.initInstance(instance, pluginInfo); | |||
| if (instance instanceof SolrCoreAware) { | |||
This reverts commit 4ef305b. reverting last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOLR-14525
For components loaded from packages SolrCoreAware, ResourceLoaderAware are not honored