Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Add thread dumps if broker node cannot be stopped #5373

Merged
merged 2 commits into from
Jul 20, 2018
Merged

MINOR: Add thread dumps if broker node cannot be stopped #5373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56984e8
MINOR: Add thread dumps if broker node cannot be stopped
wicknicks Jul 16, 2018
9665796
MINOR: Allow SIGQUIT to fail and catch all exceptions in thread_dump
wicknicks Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/kafkatest/services/kafka/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,19 @@ def stop_node(self, node, clean_shutdown=True):

for pid in pids:
node.account.signal(pid, sig, allow_fail=False)
wait_until(lambda: len(self.pids(node)) == 0, timeout_sec=60, err_msg="Kafka node failed to stop")

try:
wait_until(lambda: len(self.pids(node)) == 0, timeout_sec=60, err_msg="Kafka node failed to stop")
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should log this exception in case thread_dump raises an unexpected error. We don't want to lose the original error.

self.thread_dump(node)
raise

def thread_dump(self, node):
for pid in self.pids(node):
try:
node.account.signal(pid, signal.SIGQUIT, allow_fail=True)
except:
self.logger.warn("Could not dump threads on node")

def clean_node(self, node):
JmxMixin.clean_node(self, node)
Expand Down