New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6999: Document read-write lock usage of caching enabled stores #5351

Merged

guozhangwang merged 1 commit into apache:trunk from dongjinleekr:feature/KAFKA-6999

Jul 28, 2018

Contributor

dongjinleekr commented Jul 10, 2018

Add description for the deadlock vulnerability of ReadOnlyKeyValueStore.


          Add description on read-write lock vulnerability of ReadOnlyKeyValueS…

05fdd1d

…tore

Contributor Author

dongjinleekr commented Jul 10, 2018

Consulting ReadOnlyKeyValueStore from Processor can lead to deadlock (user mailing list)

This is draft documentation for the pitfall described above. But, I have some questions:

Is it much better to make the comments boldface?
Do we need to add similar comments to KeyValueStore, which defines read/write functionality?
As of now, this problem occurs with cache-enabled KeyValueStore which is the default. Would it much better to add comments to the class or Materialized#withCachingEnabled method?

guozhangwang added the streams label

guozhangwang merged commit 495c78d into apache:trunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels