KAFKA-7005: Remove duplicate resource class. #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccabe
reviewed
Jun 11, 2018
| @@ -33,7 +34,7 @@ import org.apache.kafka.common.protocol.types.Struct | |||
| import org.apache.kafka.common.resource.ResourceNameType | |||
| import org.apache.kafka.common.record._ | |||
| import org.apache.kafka.common.requests.CreateAclsRequest.AclCreation | |||
| import org.apache.kafka.common.requests.{Resource => RResource, ResourceType => RResourceType, _} | |||
| import org.apache.kafka.common.requests._ | |||
There was a problem hiding this comment.
Should we really be using star imports?
There was a problem hiding this comment.
In my defence, I've only removed imports here, not added them.
This is also a test class that pulls in a LOT of classes from that package - it would be a long long list!
cmccabe
reviewed
Jun 11, 2018
| import org.apache.kafka.common.errors._ | ||
| import org.apache.kafka.common.internals.Topic.GROUP_METADATA_TOPIC_NAME | ||
| import org.apache.kafka.common.network.ListenerName | ||
| import org.apache.kafka.common.protocol.{ApiKeys, Errors} | ||
| import org.apache.kafka.common.record.{CompressionType, MemoryRecords, Records, SimpleRecord} | ||
| import org.apache.kafka.common.requests.CreateAclsRequest.AclCreation | ||
| import org.apache.kafka.common.requests.CreateTopicsRequest.TopicDetails | ||
| import org.apache.kafka.common.requests.{Resource => RResource, ResourceType => RResourceType, _} | ||
| import org.apache.kafka.common.requests._ |
There was a problem hiding this comment.
Should we really be using star imports?
|
LGTM, after question about star imports is addressed |
junrao
approved these changes
Jun 11, 2018
junrao
pushed a commit
that referenced
this pull request
Jun 11, 2018
This is a follow-on change requested as part of the initial PR for KIP-290 #5117. @cmccabe requested that the `resource.Resource` class be factored out in favour of `ConfigResource` to avoid confusion between all the `Resource` implementations. Colin Patrick McCabe <[email protected]>, Jun Rao <[email protected]>
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
This is a follow-on change requested as part of the initial PR for KIP-290 apache#5117. @cmccabe requested that the `resource.Resource` class be factored out in favour of `ConfigResource` to avoid confusion between all the `Resource` implementations. Colin Patrick McCabe <[email protected]>, Jun Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for KAFKA-7005.
This is a follow-on change requested as part of the initial PR for KIP-290 #5117. @cmccabe requested that the
resource.Resourceclass be factored out in favour ofConfigResourceto avoid confusion between all theResourceimplementations.cc @cmccabe, @junrao
Committer Checklist (excluded from commit message)