Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Upgrade Gradle to 4.8 and bug fix updates for other deps #5148

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ijuma
Copy link
Contributor

@ijuma ijuma commented Jun 6, 2018

In addition to Gradle, updated snappy, owasp-dependency-check,
apache directory service api.

Gradle 4.8 fixes a fatal issue when building with Java 11, but
full support is coming in 4.9 or later.

Manually tested that jarAll and importing into IntelliJ works,
relying on PR build for the rest.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

In addition to Gradle, updated snappy, owasp-dependency-check,
apache directory service api.

Gradle 4.8 fixes a fatal issue when building with Java 11, but
full support is coming in 4.9 or later.
@ijuma ijuma requested a review from ewencp June 6, 2018 11:40
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me. Can't tell why one of the builds failed though since the jenkins logs are already gone.

@ijuma
Copy link
Contributor Author

ijuma commented Jun 7, 2018

retest this please

@ijuma
Copy link
Contributor Author

ijuma commented Jun 7, 2018

One of the jobs passed and the other failed with an unrelated exception. Merging to trunk.

@ijuma ijuma merged commit 287a92f into apache:trunk Jun 7, 2018
@ijuma ijuma deleted the gradle-4.8 branch June 7, 2018 07:28
ying-zheng pushed a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
…he#5148)

In addition to Gradle, updated snappy, owasp-dependency-check,
apache directory service api.

Gradle 4.8 fixes a fatal issue when building with Java 11, but
full support is coming in 4.9 or later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants