-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Remove deprecated valueTransformer.punctuate #4993
MINOR: Remove deprecated valueTransformer.punctuate #4993
Conversation
@mjsax this is ready for reviews now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Overall LGTM. Some nits. Feel free to merge.
@@ -49,8 +49,8 @@ | |||
public void testToInternlValueTransformerSupplierSuppliesNewTransformers() { | |||
final ValueTransformerSupplier vts = createMock(ValueTransformerSupplier.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: rename vts
@@ -49,8 +49,8 @@ | |||
public void testToInternlValueTransformerSupplierSuppliesNewTransformers() { | |||
final ValueTransformerSupplier vts = createMock(ValueTransformerSupplier.class); | |||
expect(vts.get()).andReturn(null).times(3); | |||
final InternalValueTransformerWithKeySupplier ivtwks = | |||
AbstractStream.toInternalValueTransformerSupplier(vts); | |||
final ValueTransformerWithKeySupplier ivtwks = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename ivtwks
@@ -60,15 +60,12 @@ public void testToInternlValueTransformerSupplierSuppliesNewTransformers() { | |||
|
|||
@Test | |||
public void testToInternalValueTransformerSupplierSuppliesNewTransformers() { | |||
final ValueTransformerWithKeySupplier vtwks = | |||
createMock(ValueTransformerWithKeySupplier.class); | |||
final ValueTransformerWithKeySupplier vtwks = createMock(ValueTransformerWithKeySupplier.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
…alue-transfomer-punctuate
…-record-version * apache-github/trunk: KAFKA-6894: Improve err msg when connecting processor with global store (apache#5000) KAFKA-6893; Create processors before starting acceptor in SocketServer (apache#4999) MINOR: Fix typo in ConsumerRebalanceListener JavaDoc (apache#4996) MINOR: Remove deprecated valueTransformer.punctuate (apache#4993) MINOR: Update dynamic broker configuration doc for truststore update (apache#4954) KAFKA-6870 Concurrency conflicts in SampledStat (apache#4985) KAFKA-6361: Fix log divergence between leader and follower after fast leader fail over (apache#4882) KAFKA-6813: Remove deprecated APIs in KIP-182, Part II (apache#4976) KAFKA-6878 Switch the order of underlying.init and initInternal (apache#4988) KAFKA-6299; Fix AdminClient error handling when metadata changes (apache#4295) KAFKA-6878: NPE when querying global state store not in READY state (apache#4978) KAFKA 6673: Implemented missing override equals method (apache#4745) KAFKA-6834: Handle compaction with batches bigger than max.message.bytes (apache#4953)
Also removed the InternalValueTransformerWithKey / Supplier which is used to mock away the deprecated punctuate function. Reviewers: Matthias J. Sax <[email protected]>
Also removed the InternalValueTransformerWithKey / Supplier which is used to mock away the deprecated punctuate function.
Committer Checklist (excluded from commit message)