MINOR: Trogdor should not assume an agent co-located with the controller #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ | |||
| public static Set<String> agentNodeNames(Topology topology) { | |||
| Set<String> set = new HashSet<>(); | |||
| for (Map.Entry<String, Node> entry : topology.nodes().entrySet()) { | |||
| if (Node.Util.getTrogdorAgentPort(entry.getValue()) > 0) { | |||
| if (entry.getValue().getConfig(Platform.Config.TROGDOR_AGENT_PORT) != null) { | |||
There was a problem hiding this comment.
I think the test failure in the PR builds are related to this change. MiniTrogdorCluster used in the tests sets agent port to zero on the coordinator, so this check doesn't work?
cmccabe
force-pushed
the
do_not_assume_colocation
branch
from
01265f2
to
e901037
Compare
rajinisivaram
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.