Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: time-out hanging ZooKeeperClientTest #14855

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

lucasbru
Copy link
Member

As described in KAFKA-9470, testBlockOnRequestCompletionFromStateChangeHandler will block for hours occasionally.

See, for example, here: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14758/10/pipeline/12/

If it passes, it takes 0.5 seconds, so a minute timeout should be safe.

This is not a fix for KAFKA-9470, it's just aiming to make the CI more stable.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

As described in KAFKA-9470, testBlockOnRequestCompletionFromStateChangeHandler
will block for hours occasionally.
Copy link
Contributor

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mjsax mjsax merged commit f3e776f into apache:trunk Nov 28, 2023
1 check failed
ex172000 pushed a commit to ex172000/kafka that referenced this pull request Dec 15, 2023
As described in KAFKA-9470, testBlockOnRequestCompletionFromStateChangeHandler
will block for hours occasionally.

If it passes, it takes 0.5 seconds, so a minute timeout should be safe.

This is not a fix for KAFKA-9470, it's just aiming to make the CI more stable.

Reviewers: David Jacot <[email protected]>, Matthias J. Sax <[email protected]>
yyu1993 pushed a commit to yyu1993/kafka that referenced this pull request Feb 15, 2024
As described in KAFKA-9470, testBlockOnRequestCompletionFromStateChangeHandler
will block for hours occasionally.

If it passes, it takes 0.5 seconds, so a minute timeout should be safe.

This is not a fix for KAFKA-9470, it's just aiming to make the CI more stable.

Reviewers: David Jacot <[email protected]>, Matthias J. Sax <[email protected]>
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
As described in KAFKA-9470, testBlockOnRequestCompletionFromStateChangeHandler
will block for hours occasionally.

If it passes, it takes 0.5 seconds, so a minute timeout should be safe.

This is not a fix for KAFKA-9470, it's just aiming to make the CI more stable.

Reviewers: David Jacot <[email protected]>, Matthias J. Sax <[email protected]>
clolov pushed a commit to clolov/kafka that referenced this pull request Apr 5, 2024
As described in KAFKA-9470, testBlockOnRequestCompletionFromStateChangeHandler
will block for hours occasionally.

If it passes, it takes 0.5 seconds, so a minute timeout should be safe.

This is not a fix for KAFKA-9470, it's just aiming to make the CI more stable.

Reviewers: David Jacot <[email protected]>, Matthias J. Sax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants