-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-13129: replace describe topic via zk with describe users #11115
Conversation
@ijuma @rondagostino , please help take a look. Thank you. Verified in my local env that the test verification can be passed. |
@@ -220,16 +220,15 @@ def create(self, path, chroot=None, value=""): | |||
output = self.nodes[0].account.ssh_output(cmd) | |||
self.logger.debug(output) | |||
|
|||
def describe(self, topic): | |||
def describeUsers(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace the original describe
topic method with describeUsers
since describe topic via zk is not supported anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@showuon |
@ijuma , I have to admit that I cannot complete the I checked the system tests results that run by @rondagostino in this PR: #10982 before the Sorry, and thank you. |
Replace the unsupported describe topic via zk with describe users to fix the system tests. For the upgrade_test case where TLS support is not required, use list_acls instead. Reviewers: Ismael Juma <[email protected]>
No worries, I ran a few variations and they look good. Also cherry-picked this to 3.0. |
…e#11115) Replace the unsupported describe topic via zk with describe users to fix the system tests. For the upgrade_test case where TLS support is not required, use list_acls instead. Reviewers: Ismael Juma <[email protected]>
Replace the unsupported describe topic via zk with describe users to fix the system tests.
For the
upgrade_test
case where TLS support is not required, uselist_acls
instead.Committer Checklist (excluded from commit message)