Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-13129: replace describe topic via zk with describe users #11115

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Jul 23, 2021

Replace the unsupported describe topic via zk with describe users to fix the system tests.
For the upgrade_test case where TLS support is not required, use list_acls instead.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Contributor Author

showuon commented Jul 23, 2021

@ijuma @rondagostino , please help take a look. Thank you.

Verified in my local env that the test verification can be passed.

@@ -220,16 +220,15 @@ def create(self, path, chroot=None, value=""):
output = self.nodes[0].account.ssh_output(cmd)
self.logger.debug(output)

def describe(self, topic):
def describeUsers(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace the original describe topic method with describeUsers since describe topic via zk is not supported anymore.

Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma ijuma merged commit f959e6c into apache:trunk Jul 23, 2021
@ijuma
Copy link
Contributor

ijuma commented Jul 23, 2021

@showuon upgrade_test passes with these changes, I assume?

@showuon
Copy link
Contributor Author

showuon commented Jul 23, 2021

@ijuma , I have to admit that I cannot complete the upgrade_test test successfully in my local environment, and I think that's because my machine is not power enough to complete it. So sometimes I get "Kafka server didn't finish startup in 60 seconds", and sometimes I get "Replicas did not rejoin the ISR in a reasonable amount of time".

I checked the system tests results that run by @rondagostino in this PR: #10982 before the configCommand change merged, all upgrade_test are passed. So, I assume the only issue we have now for upgrade_test is zk.describe(). At least, I can confirmed that the zk.describe() failure is fixed now.

Sorry, and thank you.

ijuma pushed a commit that referenced this pull request Jul 23, 2021
Replace the unsupported describe topic via zk with describe users to fix the system tests.
For the upgrade_test case where TLS support is not required, use list_acls instead.

Reviewers: Ismael Juma <[email protected]>
@ijuma
Copy link
Contributor

ijuma commented Jul 23, 2021

No worries, I ran a few variations and they look good. Also cherry-picked this to 3.0.

xdgrulez pushed a commit to xdgrulez/kafka that referenced this pull request Dec 22, 2021
…e#11115)

Replace the unsupported describe topic via zk with describe users to fix the system tests.
For the upgrade_test case where TLS support is not required, use list_acls instead.

Reviewers: Ismael Juma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants