MINOR: update doc for default assignor change #11009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ableegoldman , I found I forgot to update the doc to reflect the default assignor change. Please take a look. Thanks. |
showuon
force-pushed
the
defaultAssignorDoc
branch
from
4ccd026
to
a9e5557
Compare
Comment on lines
124
to
125
| "<p>The default assignor is [RangeAssignor, CooperativeStickyAssignor], which will use RangeAssignor to do assignment, " + | ||
| "but just needs 1 rolling bounce to upgrade to CooperativeStickyAssignor</p>" + |
There was a problem hiding this comment.
Suggested change
| "<p>The default assignor is [RangeAssignor, CooperativeStickyAssignor], which will use RangeAssignor to do assignment, " + | |
| "but just needs 1 rolling bounce to upgrade to CooperativeStickyAssignor</p>" + | |
| "<p>The default assignor is [RangeAssignor, CooperativeStickyAssignor], which will use the RangeAssignor by default, " + | |
| "but allows upgrading to the CooperativeStickyAssignor with just a single rolling bounce that removes the RangeAssignor from the list</p>" + |
ableegoldman
approved these changes
Jul 13, 2021
|
Previous build has one test group timeout. Re-trigger it again. |
|
Seeing as these are just docs changes and at least one build passed completely while others just had a handful of flaky tests fail, I think we can go ahead and merge this |
ableegoldman
pushed a commit
that referenced
this pull request
Jul 13, 2021
Update the doc and upgrade doc for default assignor change. REF: #10903 Reviewers: Anna Sophie Blee-Goldman <[email protected]>
|
Merged to trunk and cherrypicked to 3.0 |
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
Update the doc and upgrade doc for default assignor change. REF: apache#10903 Reviewers: Anna Sophie Blee-Goldman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the doc and upgrade doc for default assignor change.
REF: #10903
Committer Checklist (excluded from commit message)