Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: fix typo in config for eos-v2 docs of the upgrade guide #11001

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

ableegoldman
Copy link
Contributor

One of the configs has a typo and should have been exactly_once _v2 rather than just exactly_once

Copy link
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @ableegoldman !

Please remember to cherry-pick this to the 3.0 branch (cc @kkonstantine )

@ableegoldman
Copy link
Contributor Author

Alright I'm just going to merge this since it's a trivial typo fix. Ran the streams tests locally as a sanity check and we're all good

@ableegoldman ableegoldman merged commit 53f9b04 into apache:trunk Jul 8, 2021
ableegoldman added a commit that referenced this pull request Jul 8, 2021
One of the configs has a typo and should have been exactly_once _v2 rather than just exactly_once

Reviewers: John Roesler <[email protected]>
@ableegoldman
Copy link
Contributor Author

Merged to trunk and cherrypicked to 3.0

@ableegoldman ableegoldman deleted the MINOR-fix-eos-v2-docs-typo branch July 8, 2021 21:42
xdgrulez pushed a commit to xdgrulez/kafka that referenced this pull request Dec 22, 2021
…e#11001)

One of the configs has a typo and should have been exactly_once _v2 rather than just exactly_once

Reviewers: John Roesler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants