Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries #10657

Merged
merged 1 commit into from
May 11, 2021
Merged

KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries #10657

merged 1 commit into from
May 11, 2021

Conversation

vitojeng
Copy link
Contributor

@vitojeng vitojeng commented May 9, 2021 •
edited
Loading

follow-up #8200

KAFKA-5876's PR break into multiple parts, this PR is part 4 - apply InvalidStateStorePartitionException

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vitojeng
Copy link
Contributor Author

vitojeng commented May 9, 2021

@ableegoldman Please take a look :)

ableegoldman
ableegoldman approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an easy one. Nice 😄

LGTM, and test failures are only in the constantly flaky RaftClusterTest.

@ableegoldman ableegoldman merged commit fae0784 into apache:trunk May 11, 2021
@ableegoldman
Copy link
Contributor

Merged to trunk

@vitojeng
Copy link
Contributor Author

@ableegoldman Thanks. :)

@vitojeng vitojeng deleted the 5876-apply-InvalidStateStorePartitionException branch May 11, 2021 05:49
ijuma added a commit to ijuma/kafka that referenced this pull request May 16, 2021
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into reduce-produc…
00c29d0 
…e-allocations-lz4

* apache-github/trunk: (155 commits)
  KAFKA-12728: Upgrade gradle to 7.0.2 and shadow to 7.0.0 (apache#10606)
  KAFKA-12778: Fix QuorumController request timeouts and electLeaders (apache#10688)
  KAFKA-12754: Improve endOffsets for TaskMetadata (apache#10634)
  Rework on KAFKA-3968: fsync the parent directory of a segment file when the file is created (apache#10680)
  MINOR: set replication.factor to 1 to make StreamsBrokerCompatibilityService work with old broker (apache#10673)
  MINOR: prevent cleanup() from being called while Streams is still shutting down (apache#10666)
  KAFKA-8326: Introduce List Serde (apache#6592)
  KAFKA-12697: Add Global Topic and Partition count metrics to the Quorum Controller (apache#10679)
  KAFKA-12648: MINOR - Add TopologyMetadata.Subtopology class for subtopology metadata (apache#10676)
  MINOR: Update jacoco to 0.8.7 for JDK 16 support (apache#10654)
  MINOR: exclude all `src/generated` and `src/generated-test` (apache#10671)
  KAFKA-12772: Move all transaction state transition rules into their states (apache#10667)
  KAFKA-12758 Added `server-common` module to have server side common classes.  (apache#10638)
  MINOR Removed copying storage libraries specifically as they are already copied. (apache#10647)
  KAFKA-5876: KIP-216 Part 4, Apply InvalidStateStorePartitionException for Interactive Queries (apache#10657)
  KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix (apache#10643)
  MINOR: remove unnecessary placeholder from WorkerSourceTask#recordSent (apache#10659)
  MINOR: Remove unused `scalatest` definition from `dependencies.gradle` (apache#10655)
  MINOR: checkstyle version upgrade: 8.20 -> 8.36.2 (apache#10656)
  KAFKA-12464: minor code cleanup and additional logging in constrained sticky assignment (apache#10645)
  ...
@ableegoldman
Copy link
Contributor

ableegoldman commented May 26, 2021 •
edited
Loading

Hey @vitojeng , was this the final PR for KIP-216? If not is the next one available yet? No rush, just want to make sure you haven't been waiting on reviews this whole time 🙂

edit: I copied over the list of exceptions on the KIP to the ticket description and marked those I could find PRs for as done. Please let me know if I missed any (to answer my question above, it seems there are three exceptions/PRs remaining, is that correct?)

@vitojeng
Copy link
Contributor Author

@ableegoldman Thanks for your concern, KIP-216 still in progress. 🙂
It's really busy in the last two weeks, some bad things continue to happen in Taiwan.
I will stick to it until KIP-216 is completed. 💪

Please let me know if I missed any (to answer my question above, it seems there are three exceptions/PRs remaining, is that correct?)

Yes, you are right. The three exceptions are the most important part in KIP-216, IMO.
I wish to submit the next PR in next week.

@ableegoldman
Copy link
Contributor

No worries! Take care of yourself first, KIP-216 can wait for you 🙂 I just wanted to check in and mostly, make sure you don't need anything from my end. I'll keep an eye out for the next parts whenever they're ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ableegoldman ableegoldman ableegoldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitojeng @ableegoldman