-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: can not get generated keys value. #2603
bugfix: can not get generated keys value. #2603
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2603 +/- ##
=============================================
- Coverage 50.91% 50.79% -0.12%
+ Complexity 2815 2811 -4
=============================================
Files 558 558
Lines 17941 17936 -5
Branches 2129 2124 -5
=============================================
- Hits 9134 9111 -23
- Misses 7938 7957 +19
+ Partials 869 868 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #2603 +/- ##
=============================================
- Coverage 51.13% 51.12% -0.01%
+ Complexity 2849 2847 -2
=============================================
Files 566 566
Lines 18077 18086 +9
Branches 2142 2142
=============================================
+ Hits 9243 9246 +3
- Misses 7945 7950 +5
- Partials 889 890 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix: oracle and postgresql insert executor after not get generated keys value.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews