Undo pr 1033 and adjust the maven plugin of seata-all.xml #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1095 +/- ##
==========================================
Coverage 41.83% 41.83%
Complexity 1361 1361
==========================================
Files 243 243
Lines 10111 10111
Branches 1319 1319
==========================================
Hits 4230 4230
Misses 5334 5334
Partials 547 547Continue to review full report at Codecov.
|
lovepoem
requested changes
May 23, 2019
| @@ -428,7 +428,7 @@ | |||
| <createSourcesJar>true</createSourcesJar> | |||
| <promoteTransitiveDependencies>false</promoteTransitiveDependencies> | |||
| <keepDependenciesWithProvidedScope>false</keepDependenciesWithProvidedScope> | |||
| <createDependencyReducedPom>false</createDependencyReducedPom> | |||
| <createDependencyReducedPom>true</createDependencyReducedPom> | |||
There was a problem hiding this comment.
The switch is open , then can create createDependencyReducedPom .xml files，so please add this file in .gitignore
lovepoem
approved these changes
May 23, 2019
nick-tan
pushed a commit
to nick-tan/seata
that referenced
this pull request
Jul 12, 2019
* undo pr apache#1033 * undo pr apache#1033 * modify file.conf * Update .gitignore * Update .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change points:
Set the createDependencyReducedPom to true.
The code of seata-* has all be packed into the seata-all.jar, and should not be inclueded in the seata-all.pom.
Change the configs of maven-javadoc-plugin in seata-all.xml