-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18368. Fixes ITestCustomSigner for access point names with '-' #4634
Merged
mukund-thakur
merged 2 commits into
apache:trunk
from
ahmarsuhail:HADOOP-18368-fix-ITestCustomSigner
Aug 1, 2022
Merged
HADOOP-18368. Fixes ITestCustomSigner for access point names with '-' #4634
mukund-thakur
merged 2 commits into
apache:trunk
from
ahmarsuhail:HADOOP-18368-fix-ITestCustomSigner
Aug 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@mukund-thakur small PR which fixes an issue with ITestCustomSigner, could you take a look please? |
mukund-thakur
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
mukund-thakur
pushed a commit
that referenced
this pull request
Aug 1, 2022
…#4634) Contributed By: Ahmar Suhail <[email protected]>
pushed to branch-3.3 as well. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…apache#4634) Contributed By: Ahmar Suhail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Jira: https://issues.apache.org/jira/browse/HADOOP-18368
ITestCustomSigner was failing for access point names that had '-', eg: test-custom-signer. This PR updates the logic so access point name is now extracted using substring. Eg, if
bucketName = test-custom-signer-12345678
where12345678
is the aws account id, we can get access point name bybucketName.substring(0, bucketName.length() - (accountId.length() + 1))
, with the+ 1
being for removing the-
before the account id.How was this patch tested?
Since it's only updating the
ITestCustomSigner
, I tested by runningITestCustomSigner
with: