HDFS-16680. Skip libhdfspp Valgrind tests on Windows #4611

GauthamBanasandra · 2022-07-22T17:15:39Z

Description of PR

The CMake test libhdfs_mini_stress_valgrind requires Valgrind -

hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt

Lines 172 to 175 in 221eb2d

    
           build_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static expect.c test_libhdfs_mini_stress.c ${OS_DIR}/thread.c) 
        
           link_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static fs reader rpc proto common connection ${PROTOBUF_LIBRARIES} ${OPENSSL_LIBRARIES} native_mini_dfs ${JAVA_JVM_LIBRARY} ${SASL_LIBRARIES}) 
        
           add_memcheck_test(libhdfs_mini_stress_valgrind_hdfspp_test_static libhdfs_mini_stress_valgrind_hdfspp_test_static) 
        
           set_target_properties(libhdfs_mini_stress_valgrind_hdfspp_test_static PROPERTIES COMPILE_DEFINITIONS "VALGRIND")

We need to skip this test on Windows since we don't have Valgrind on Windows.

How was this patch tested?

Tested this locally by building on my Windows system.
Hadoop Jenkins CI validation.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* The CMake test libhdfs_mini_stress_valgrind requires Valgrind. * This PR skips this test on Windows since Valgrind isn't available.

hadoop-yetus · 2022-07-23T06:19:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 21s		trunk passed
+1 💚	compile	4m 0s		trunk passed
+1 💚	mvnsite	0m 37s		trunk passed
+1 💚	shadedclient	69m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	3m 40s		the patch passed
+1 💚	cc	3m 40s		the patch passed
+1 💚	javac	3m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	shadedclient	22m 11s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	103m 38s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		203m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/artifact/out/Dockerfile
GITHUB PR	#4611
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 69371901e7e8 4.15.0-184-generic #194-Ubuntu SMP Thu Jun 2 18:54:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cde1b62`
Default Java	Red Hat, Inc.-1.8.0_332-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/testReport/
Max. process+thread count	607 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-23T09:35:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	25m 32s		trunk passed
+1 💚	compile	4m 10s		trunk passed
+1 💚	mvnsite	0m 51s		trunk passed
+1 💚	shadedclient	52m 54s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	3m 55s		the patch passed
+1 💚	cc	3m 56s		the patch passed
+1 💚	javac	3m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 27s		the patch passed
+1 💚	shadedclient	22m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	85m 24s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		195m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/artifact/out/Dockerfile
GITHUB PR	#4611
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 2ece93393ca8 4.15.0-184-generic #194-Ubuntu SMP Thu Jun 2 18:54:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cde1b62`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/testReport/
Max. process+thread count	593 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-23T13:34:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	25m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	30m 48s		trunk passed
+1 💚	compile	3m 42s		trunk passed
+1 💚	mvnsite	0m 43s		trunk passed
+1 💚	shadedclient	67m 7s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s		the patch passed
+1 💚	compile	3m 28s		the patch passed
+1 💚	cc	3m 28s		the patch passed
+1 💚	javac	3m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	shadedclient	31m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	107m 32s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		239m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/artifact/out/Dockerfile
GITHUB PR	#4611
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 8d8dc95deb10 4.15.0-184-generic #194-Ubuntu SMP Thu Jun 2 18:54:48 UTC 2022 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cde1b62`
Default Java	Debian-11.0.16+8-post-Debian-1deb10u1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/testReport/
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/console
versions	git=2.20.1 maven=3.6.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-23T17:11:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 35s		trunk passed
+1 💚	compile	4m 18s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	4m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	shadedclient	56m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 20s		the patch passed
+1 💚	compile	4m 4s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	cc	4m 4s		the patch passed
+1 💚	javac	4m 4s		the patch passed
+1 💚	compile	4m 1s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	cc	4m 1s		the patch passed
+1 💚	javac	4m 1s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 23s		the patch passed
+1 💚	shadedclient	22m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	107m 38s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		216m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/artifact/out/Dockerfile
GITHUB PR	#4611
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux e05e9e13aac2 4.15.0-184-generic #194-Ubuntu SMP Thu Jun 2 18:54:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `cde1b62`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/testReport/
Max. process+thread count	600 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4611/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

* The CMake test libhdfs_mini_stress_valgrind requires Valgrind. * This PR skips this test on Windows since Valgrind isn't available.

HDFS-16680. Skip libhdfspp Valgrind tests on Windows

cde1b62

* The CMake test libhdfs_mini_stress_valgrind requires Valgrind. * This PR skips this test on Windows since Valgrind isn't available.

GauthamBanasandra added the HDFS label Jul 22, 2022

GauthamBanasandra self-assigned this Jul 22, 2022

goiri approved these changes Jul 22, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

GauthamBanasandra marked this pull request as ready for review July 23, 2022 17:50

GauthamBanasandra merged commit 8f83d9f into apache:trunk Jul 23, 2022

GauthamBanasandra deleted the skip-vlg branch July 23, 2022 17:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16680. Skip libhdfspp Valgrind tests on Windows #4611

HDFS-16680. Skip libhdfspp Valgrind tests on Windows #4611

GauthamBanasandra commented Jul 22, 2022

This comment was marked as outdated.

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022

	build_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static expect.c test_libhdfs_mini_stress.c ${OS_DIR}/thread.c)
	link_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static fs reader rpc proto common connection ${PROTOBUF_LIBRARIES} ${OPENSSL_LIBRARIES} native_mini_dfs ${JAVA_JVM_LIBRARY} ${SASL_LIBRARIES})
	add_memcheck_test(libhdfs_mini_stress_valgrind_hdfspp_test_static libhdfs_mini_stress_valgrind_hdfspp_test_static)
	set_target_properties(libhdfs_mini_stress_valgrind_hdfspp_test_static PROPERTIES COMPILE_DEFINITIONS "VALGRIND")

HDFS-16680. Skip libhdfspp Valgrind tests on Windows #4611

HDFS-16680. Skip libhdfspp Valgrind tests on Windows #4611

Conversation

GauthamBanasandra commented Jul 22, 2022

Description of PR

How was this patch tested?

For code changes:

This comment was marked as outdated.

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022