HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 #4553

ashutoshcipher · 2022-07-12T00:02:20Z

Description of PR

Upgrade jetty version to 9.4.48.v20220622 to mitigate CVE-2022-2047

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-07-12T10:15:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 16s		trunk passed
+1 💚	compile	24m 51s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	21m 39s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	19m 46s		trunk passed
+1 💚	javadoc	8m 29s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 32s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	38m 26s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 59s		Maven dependency ordering for patch
+1 💚	mvninstall	24m 47s		the patch passed
+1 💚	compile	24m 18s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌	javac	24m 18s	/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 3 new + 2878 unchanged - 0 fixed = 2881 total (was 2878)
+1 💚	compile	21m 37s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌	javac	21m 37s	/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 3 new + 2674 unchanged - 0 fixed = 2677 total (was 2674)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	19m 20s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	8m 22s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 24s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	40m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	327m 51s	/patch-unit-root.txt	root in the patch failed.
+0 🆗	asflicense	1m 10s		ASF License check generated no output?
		611m 18s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestFsck
	hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
	hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4553/1/artifact/out/Dockerfile
GITHUB PR	#4553
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 189fbe74a3be 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `fd5d237`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4553/1/testReport/
Max. process+thread count	3137 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4553/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

pjfanning · 2022-07-18T11:19:06Z

@ashutoshcipher I'm not a Hadoop committer, so my review is not all that important - looks like the test failures are due to OOMs and are probably unrelated to your change. I'll run those tests locally to see if they fail for me.

jojochuang · 2022-07-18T17:25:17Z

All reviews are welcomed!

@ashutoshcipher it would be great to get rid of the deprecation warnings. Otherwise looks good to me.

hadoop-yetus · 2022-07-19T20:18:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 48s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 18s		trunk passed
+1 💚	compile	25m 13s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	22m 1s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	4m 30s		trunk passed
+1 💚	mvnsite	20m 10s		trunk passed
+1 💚	javadoc	8m 32s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 23s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 27s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	58m 21s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 56s		Maven dependency ordering for patch
+1 💚	mvninstall	25m 58s		the patch passed
+1 💚	compile	24m 52s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 52s		the patch passed
+1 💚	compile	22m 3s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	22m 3s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	checkstyle	4m 52s		the patch passed
+1 💚	mvnsite	19m 49s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	8m 21s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 28s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 28s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	58m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1071m 57s		root in the patch passed.
+1 💚	asflicense	2m 14s		The patch does not generate ASF License warnings.
		1448m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4553/2/artifact/out/Dockerfile
GITHUB PR	#4553
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 7bdfd70ef618 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `dac51e7`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4553/2/testReport/
Max. process+thread count	2863 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-common-project/hadoop-common . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4553/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

jojochuang

+1

ashutoshcipher · 2022-07-21T06:23:34Z

Thanks @jojochuang for reviewing and merging.

Co-authored-by: Ashutosh Gupta <[email protected]> (cherry picked from commit e664f81) Conflicts: LICENSE-binary Change-Id: I5a758df2551539c2780e170c3738c5b21eb0c79d

* HADOOP-18001. Upgrade jetty version to 9.4.44 (#3700). Contributed by Yuan Luo. Signed-off-by: Ayush Saxena <[email protected]> (cherry picked from commit b85c66a) * HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 (#4553) Co-authored-by: Ashutosh Gupta <[email protected]> (cherry picked from commit e664f81) Conflicts: LICENSE-binary Change-Id: I5a758df2551539c2780e170c3738c5b21eb0c79d Co-authored-by: better3471 <[email protected]> Co-authored-by: Ashutosh Gupta <[email protected]>

Co-authored-by: Ashutosh Gupta <[email protected]>

HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622

fd5d237

ashutoshcipher mentioned this pull request Jul 18, 2022

HADOOP-18343: upgrade jetty #4582

Closed

4 tasks

pjfanning mentioned this pull request Jul 18, 2022

HADOOP-18333: upgrade to jetty 9.4.48 (3.3 branch) #4583

Closed

4 tasks

fixing deprecated AllowSymLinkAliasChecker

dac51e7

jojochuang approved these changes Jul 19, 2022

View reviewed changes

jojochuang merged commit e664f81 into apache:trunk Jul 20, 2022

jojochuang mentioned this pull request Jul 20, 2022

HADOOP-18333. Upgrade jetty version to 9.4.48.v20220622 #4600

Merged

ashutoshcipher deleted the HADOOP-18333 branch July 21, 2022 06:23

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 (apache#4553)

24936c7

Co-authored-by: Ashutosh Gupta <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 #4553

HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 #4553

ashutoshcipher commented Jul 12, 2022 •

edited

Loading

hadoop-yetus commented Jul 12, 2022

pjfanning commented Jul 18, 2022

jojochuang commented Jul 18, 2022

hadoop-yetus commented Jul 19, 2022

jojochuang left a comment

ashutoshcipher commented Jul 21, 2022

HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 #4553

HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622 #4553

Conversation

ashutoshcipher commented Jul 12, 2022 • edited Loading

Description of PR

For code changes:

hadoop-yetus commented Jul 12, 2022

pjfanning commented Jul 18, 2022

jojochuang commented Jul 18, 2022

hadoop-yetus commented Jul 19, 2022

jojochuang left a comment

Choose a reason for hiding this comment

ashutoshcipher commented Jul 21, 2022

ashutoshcipher commented Jul 12, 2022 •

edited

Loading