HADOOP-17676. Restrict imports from org.apache.curator.shaded #2969

virajjasani · 2021-05-02T06:39:43Z

No description provided.

aajisaka

+1 pending Jenkins.

Manually edited a file and run mvn install -DskipTests with OpenJDK 8, 11, and 16. The output looks good:

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (banned-illegal-imports) @ hadoop-yarn-common ---
[WARNING] Rule 0: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:

Banned imports detected:

Reason: Use hadoop-thirdparty shaded instead of curator shaded
	in file: org/apache/hadoop/yarn/webapp/view/TwoColumnLayout.java
		org.apache.curator.shaded.com.google.common.collect.Lists (Line: 28, Matched by: org.apache.curator.shaded.**)

Analysis took 0 seconds

hadoop-yetus · 2021-05-02T23:40:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 25s		trunk passed
+1 💚	compile	21m 8s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 53s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	25m 29s		trunk passed
+1 💚	javadoc	7m 17s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	7m 41s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	shadedclient	127m 21s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	19m 55s		the patch passed
+1 💚	compile	20m 18s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 18s		the patch passed
+1 💚	compile	18m 1s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 1s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	20m 8s		the patch passed
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	7m 24s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	7m 48s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	shadedclient	29m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	780m 4s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 28s		The patch does not generate ASF License warnings.
		1019m 43s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.TestViewDistributedFileSystem
	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.tools.fedbalance.procedure.TestBalanceProcedureScheduler
	hadoop.tools.fedbalance.TestDistCpProcedure
	hadoop.tools.dynamometer.TestDynamometerInfra

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/1/artifact/out/Dockerfile
GITHUB PR	#2969
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname	Linux a1073b4ff22f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a571170`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/1/testReport/
Max. process+thread count	3073 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-05-03T06:30:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 21s		trunk passed
+1 💚	compile	20m 36s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 56s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	25m 45s		trunk passed
+1 💚	javadoc	7m 18s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	7m 50s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	shadedclient	127m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	19m 36s		the patch passed
+1 💚	compile	20m 14s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 14s		the patch passed
+1 💚	compile	18m 8s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	20m 7s		the patch passed
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	7m 20s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	7m 51s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	shadedclient	29m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	775m 27s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 34s		The patch does not generate ASF License warnings.
		1014m 43s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
	hadoop.hdfs.server.federation.router.TestRouterRpc
	hadoop.fs.contract.router.web.TestRouterWebHDFSContractCreate
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.tools.dynamometer.TestDynamometerInfra
	hadoop.tools.fedbalance.procedure.TestBalanceProcedureScheduler
	hadoop.tools.fedbalance.TestDistCpProcedure
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAsyncScheduling
	hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/4/artifact/out/Dockerfile
GITHUB PR	#2969
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname	Linux 2810ba1e4266 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a571170`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/4/testReport/
Max. process+thread count	3459 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/4/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-05-03T06:39:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 11s		trunk passed
+1 💚	compile	23m 45s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	20m 24s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	26m 40s		trunk passed
+1 💚	javadoc	8m 0s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	8m 11s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	shadedclient	137m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	20m 51s		the patch passed
+1 💚	compile	21m 1s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	21m 1s		the patch passed
+1 💚	compile	19m 36s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	19m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	21m 10s		the patch passed
+1 💚	xml	0m 2s		The patch has no ill-formed XML file.
+1 💚	javadoc	7m 48s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	8m 0s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	shadedclient	30m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	768m 48s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 30s		The patch does not generate ASF License warnings.
		1024m 13s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRpc
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
	hadoop.hdfs.TestRollingUpgrade
	hadoop.tools.fedbalance.procedure.TestBalanceProcedureScheduler
	hadoop.tools.fedbalance.TestDistCpProcedure
	hadoop.tools.dynamometer.TestDynamometerInfra
	hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/2/artifact/out/Dockerfile
GITHUB PR	#2969
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname	Linux 07a868948629 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a571170`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/2/testReport/
Max. process+thread count	2943 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2969/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-05-03T06:48:45Z

Thanks for the review @aajisaka

aajisaka · 2021-05-03T16:10:38Z

Merged. Thank you @virajjasani

Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 62bcc79)

…#2969) Signed-off-by: Akira Ajisaka <[email protected]>

HADOOP-17676. Restrict imports from org.apache.curator.shaded

a571170

virajjasani mentioned this pull request May 2, 2021

HADOOP-17653. Do not use guava's Files.createTempDir(). #2945

Merged

aajisaka approved these changes May 2, 2021

View reviewed changes

aajisaka merged commit 62bcc79 into apache:trunk May 3, 2021

aajisaka pushed a commit that referenced this pull request May 3, 2021

HADOOP-17676. Restrict imports from org.apache.curator.shaded (#2969)

658bb49

Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 62bcc79)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17676. Restrict imports from org.apache.curator.shaded (apache…

f5d333e

…#2969) Signed-off-by: Akira Ajisaka <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17676. Restrict imports from org.apache.curator.shaded #2969

HADOOP-17676. Restrict imports from org.apache.curator.shaded #2969

virajjasani commented May 2, 2021

aajisaka left a comment

hadoop-yetus commented May 2, 2021

hadoop-yetus commented May 3, 2021

hadoop-yetus commented May 3, 2021

virajjasani commented May 3, 2021

aajisaka commented May 3, 2021

HADOOP-17676. Restrict imports from org.apache.curator.shaded #2969

HADOOP-17676. Restrict imports from org.apache.curator.shaded #2969

Conversation

virajjasani commented May 2, 2021

aajisaka left a comment

Choose a reason for hiding this comment

hadoop-yetus commented May 2, 2021

hadoop-yetus commented May 3, 2021

hadoop-yetus commented May 3, 2021

virajjasani commented May 3, 2021

aajisaka commented May 3, 2021