Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16870. Use spotbugs-maven-plugin instead of findbugs-maven-plugin #2753

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Mar 9, 2021

JIRA: https://issues.apache.org/jira/browse/HADOOP-16870

In addition to #2454, upgraded SpotBugs to 4.2.2 and spotbugs-maven-plugin to 4.2.0 to fix spotbugs/spotbugs#1161

Use spotbugs instead of findbugs. Removed findbugs from the hadoop build images,
and added spotbugs in the images instead.
@asf-cloudbees-jenkins-ci-hadoop

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2753/1/console in case of problems.

@asf-cloudbees-jenkins-ci-hadoop

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2753/2/console in case of problems.

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

  • mvn compile spotbugs:spotbugs worked in the container launched by start-build-env.sh.
  • convertXmlToText and computeBugHistory worked in the container.

@aajisaka aajisaka merged commit 23b343a into apache:trunk Mar 11, 2021
@aajisaka
Copy link
Member Author

Merged. Thank you @iwasakims

@aajisaka aajisaka deleted the HADOOP-16870-2 branch March 11, 2021 01:56
aajisaka added a commit that referenced this pull request Mar 11, 2021
…gin (#2753)

Removed findbugs from the hadoop build images and added spotbugs instead.
Upgraded SpotBugs to 4.2.2 and spotbugs-maven-plugin to 4.2.0.

Reviewed-by: Masatake Iwasaki <[email protected]>
(cherry picked from commit 23b343a)

 Conflicts:
	dev-support/docker/Dockerfile
	hadoop-project/pom.xml
aajisaka added a commit that referenced this pull request Mar 11, 2021
…gin (#2753)

Removed findbugs from the hadoop build images and added spotbugs instead.
Upgraded SpotBugs to 4.2.2 and spotbugs-maven-plugin to 4.2.0.

Reviewed-by: Masatake Iwasaki <[email protected]>
(cherry picked from commit 23b343a)

 Conflicts:
	dev-support/docker/Dockerfile
	hadoop-project/pom.xml

(cherry picked from commit de2904f)

 Conflicts:
	dev-support/docker/Dockerfile_aarch64
	hadoop-cloud-storage-project/hadoop-cos/pom.xml
	hadoop-common-project/hadoop-registry/pom.xml
	hadoop-project/pom.xml
aajisaka added a commit that referenced this pull request Mar 26, 2021
…gin (#2753)

Removed findbugs from the hadoop build images and added spotbugs instead.
Upgraded SpotBugs to 4.2.2 and spotbugs-maven-plugin to 4.2.0.

Reviewed-by: Masatake Iwasaki <[email protected]>
(cherry picked from commit 23b343a)

 Conflicts:
	dev-support/docker/Dockerfile
	hadoop-project/pom.xml

(cherry picked from commit de2904f)

 Conflicts:
	dev-support/docker/Dockerfile_aarch64
	hadoop-cloud-storage-project/hadoop-cos/pom.xml
	hadoop-common-project/hadoop-registry/pom.xml
	hadoop-project/pom.xml

(cherry picked from commit 0b27850)

 Conflicts:
	dev-support/docker/Dockerfile
	hadoop-project/pom.xml
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
…gin (apache#2753)

Removed findbugs from the hadoop build images and added spotbugs instead.
Upgraded SpotBugs to 4.2.2 and spotbugs-maven-plugin to 4.2.0.

Reviewed-by: Masatake Iwasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsupportedOperationException after upgrade from 3.1.12 to 4.0.4
2 participants