-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-15485. Fix outdated properties of JournalNode when performing rollback #2162
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable. Can you add a unit test?
Thanks for your review @jojochuang , I think present UTs can cover this case and it's hard to add another one for this. |
Thanks. Merged to trunk. I'll see if it makes sense to cherrypick to lower branches. |
When rollback HDFS cluster, properties in JNStorage won't be refreshed after the storage dir changed. It leads to exceptions when starting NameNode.
We add refresh method which will refresh properties of JournalNode after rollback has changed the previous dir to current.