HDFS-14522. Allow compact property description in xml in httpfs. #1737

iwasakims · 2019-12-04T12:07:18Z

No description provided.

hadoop-yetus · 2019-12-04T13:14:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	23m 0s	trunk passed
+1 💚	compile	0m 24s	trunk passed
+1 💚	checkstyle	0m 19s	trunk passed
+1 💚	mvnsite	0m 34s	trunk passed
+1 💚	shadedclient	14m 27s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 21s	trunk passed
+0 🆗	spotbugs	0m 44s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 41s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 8 unchanged - 5 fixed = 9 total (was 13)
+1 💚	mvnsite	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 36s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s	the patch passed
+1 💚	findbugs	0m 54s	the patch passed
		_ Other Tests _
-1 ❌	unit	4m 39s	hadoop-hdfs-httpfs in the patch failed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		65m 48s

Reason	Tests
Failed junit tests	hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/1/artifact/out/Dockerfile
GITHUB PR	#1737
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux bf9cb35d983e 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `47fdae7`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/1/testReport/
Max. process+thread count	596 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-12-04T13:46:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	31m 48s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 42s	trunk passed
+1 💚	compile	0m 23s	trunk passed
+1 💚	checkstyle	0m 20s	trunk passed
+1 💚	mvnsite	0m 31s	trunk passed
+1 💚	shadedclient	14m 36s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 21s	trunk passed
+0 🆗	spotbugs	0m 42s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 41s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
-0 ⚠️	checkstyle	0m 14s	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 1 new + 7 unchanged - 5 fixed = 8 total (was 12)
+1 💚	mvnsite	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 10s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 18s	the patch passed
+1 💚	findbugs	0m 45s	the patch passed
		_ Other Tests _
-1 ❌	unit	4m 24s	hadoop-hdfs-httpfs in the patch failed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		93m 48s

Reason	Tests
Failed junit tests	hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/2/artifact/out/Dockerfile
GITHUB PR	#1737
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux a6c05fa1f144 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `47fdae7`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/2/testReport/
Max. process+thread count	615 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

...ject/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestConfigurationUtils.java

hadoop-yetus · 2019-12-06T06:21:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	27m 18s	trunk passed
+1 💚	compile	0m 26s	trunk passed
+1 💚	checkstyle	0m 21s	trunk passed
+1 💚	mvnsite	0m 35s	trunk passed
+1 💚	shadedclient	17m 38s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s	trunk passed
+0 🆗	spotbugs	0m 50s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 48s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
-0 ⚠️	checkstyle	0m 15s	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 2 new + 8 unchanged - 5 fixed = 10 total (was 13)
+1 💚	mvnsite	0m 35s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedclient	17m 17s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 23s	the patch passed
+1 💚	findbugs	0m 59s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 54s	hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		77m 19s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/3/artifact/out/Dockerfile
GITHUB PR	#1737
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux b7ef34bafb31 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `19512b2`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/3/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/3/testReport/
Max. process+thread count	594 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

goiri · 2019-12-07T00:26:04Z

...ject/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestConfigurationUtils.java

+    ConfigurationUtils.load(conf,
+        Thread.currentThread()
+            .getContextClassLoader().getResource(TESTFILE).openStream());
+    assertEquals(conf.size(), 2);


These asserts are revert (also 132).

goiri · 2019-12-07T00:26:44Z

...ject/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestConfigurationUtils.java

    Configuration conf = new Configuration(false);
    ConfigurationUtils.load(conf, is);
+    assertEquals(conf.get("key1"), "val1");


Reverse (expected first)

fixed the order or arguments of assertEquals.

goiri · 2019-12-07T00:28:12Z

Let's fix the checkstyle issues.

…first.

hadoop-yetus · 2019-12-09T01:49:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 5s	trunk passed
+1 💚	compile	0m 24s	trunk passed
+1 💚	checkstyle	0m 21s	trunk passed
+1 💚	mvnsite	0m 36s	trunk passed
+1 💚	shadedclient	14m 45s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s	trunk passed
+0 🆗	spotbugs	0m 48s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 46s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
-0 ⚠️	checkstyle	0m 14s	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 2 new + 8 unchanged - 5 fixed = 10 total (was 13)
+1 💚	mvnsite	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	15m 6s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 19s	the patch passed
+1 💚	findbugs	0m 45s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 26s	hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		63m 16s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/4/artifact/out/Dockerfile
GITHUB PR	#1737
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 394666e0daa1 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6d970d8`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/4/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/4/testReport/
Max. process+thread count	617 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-12-09T02:04:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 17s	trunk passed
+1 💚	compile	0m 23s	trunk passed
+1 💚	checkstyle	0m 18s	trunk passed
+1 💚	mvnsite	0m 35s	trunk passed
+1 💚	shadedclient	15m 2s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s	trunk passed
+0 🆗	spotbugs	0m 40s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 37s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	checkstyle	0m 13s	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 0 new + 8 unchanged - 5 fixed = 8 total (was 13)
+1 💚	mvnsite	0m 26s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	14m 55s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 18s	the patch passed
+1 💚	findbugs	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 28s	hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		63m 12s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/5/artifact/out/Dockerfile
GITHUB PR	#1737
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 64101692556f 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6d970d8`
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/5/testReport/
Max. process+thread count	610 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1737/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

iwasakims · 2019-12-10T01:32:10Z

Thanks for the review, @goiri.

…che#1737)

HDFS-14522. Allow compact property description in xml in httpfs.

397adc9

iwasakims force-pushed the HDFS-14522 branch from d5a6426 to 397adc9 Compare December 4, 2019 12:11

goiri reviewed Dec 4, 2019

View reviewed changes

...ject/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/util/TestConfigurationUtils.java Show resolved Hide resolved

moved test configuraiton to test resource file.

ec0d8f0

goiri reviewed Dec 7, 2019

View reviewed changes

iwasakims added 2 commits December 9, 2019 09:44

fixed the order of arguments of assertEquals as expected value comes …

6c71324

…first.

addressed checkstyle warnings.

3a79622

goiri approved these changes Dec 9, 2019

View reviewed changes

iwasakims merged commit 4dffd81 into apache:trunk Dec 10, 2019

RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020

HDFS-14522. Allow compact property description in xml in httpfs. (apa…

e216bd2

…che#1737)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-14522. Allow compact property description in xml in httpfs. #1737

HDFS-14522. Allow compact property description in xml in httpfs. #1737

iwasakims commented Dec 4, 2019

hadoop-yetus commented Dec 4, 2019

hadoop-yetus commented Dec 4, 2019

hadoop-yetus commented Dec 6, 2019

goiri Dec 7, 2019

goiri Dec 7, 2019

iwasakims Dec 9, 2019

goiri commented Dec 7, 2019

hadoop-yetus commented Dec 9, 2019

hadoop-yetus commented Dec 9, 2019

iwasakims commented Dec 10, 2019

HDFS-14522. Allow compact property description in xml in httpfs. #1737

HDFS-14522. Allow compact property description in xml in httpfs. #1737

Conversation

iwasakims commented Dec 4, 2019

hadoop-yetus commented Dec 4, 2019

hadoop-yetus commented Dec 4, 2019

hadoop-yetus commented Dec 6, 2019

goiri Dec 7, 2019

Choose a reason for hiding this comment

goiri Dec 7, 2019

Choose a reason for hiding this comment

iwasakims Dec 9, 2019

Choose a reason for hiding this comment

goiri commented Dec 7, 2019

hadoop-yetus commented Dec 9, 2019

hadoop-yetus commented Dec 9, 2019

iwasakims commented Dec 10, 2019