Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35751][table] Migrate SplitPythonConditionFromCorrelateRule to java #25014

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liuyongvs
Copy link
Contributor

What is the purpose of the change

A bit reasoning for the change

The reason is that since 1.28.0 ( CALCITE-4787 - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( CALCITE-4839 - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code.

The PR migrates PythonUtil and SplitPythonConditionFromCorrelateRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@liuyongvs liuyongvs changed the title Split python condition from correlate rule [FLINK-35751][table] Migrate SplitPythonConditionFromCorrelateRule to java Jul 3, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Jul 3, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs liuyongvs force-pushed the SplitPythonConditionFromCorrelateRule branch 2 times, most recently from cf69d9b to e0b724a Compare July 4, 2024 05:03
@liuyongvs liuyongvs force-pushed the SplitPythonConditionFromCorrelateRule branch from e0b724a to 7832cb9 Compare July 4, 2024 05:10
@liuyongvs
Copy link
Contributor Author

hi @snuyanzin will you help review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants