-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Java version dependent on Flink. #24996
base: master
Are you sure you want to change the base?
Conversation
@flinkbot run azure |
Why not ‘marge’? |
README.md
Outdated
* Maven (we require version 4.0.0) | ||
* Java 17 or 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the CIs are still working with 3.8.6, release activities still require 3.8.6
there was no official drop of 8 and 11
I think both jdk and maven changes like that will require not only doc update but also discussing this with community first via mailing list, CI updates, release doc updates, may be something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this document, Java8 and Java11 have been removed in flink 2.0,
this is planned however not done yet, and this means not only doc update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is flink 2.0.
According to this document, Java8 and Java11 have been removed in flink 2.0, Java 17 is the default version and Java 21 is also supported.
The Maven version was selected as the minimum Java version supported by flink2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at code there is still maven 3.8.6
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip |
if you look at ci pipelines there is still jdk8
e.g.
jdk: 8 |
jdk: 8 |
these are just some examples, in fact there are more
Also if you look at release doc (https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release)
there are maven 3.8.6
and java 8
all this should be discussed/fixed before the doc update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I canceled the Maven version modification.
See the link here.