[FLINK-20539][table-planner] Fix type mismatch when casting ROW #24994
+180
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuyangzhong
commented
Jul 2, 2024
| createTestItem( | ||
| "ROW<f0 INT NOT NULL, f1 BOOLEAN>", | ||
| DataTypes.ROW( | ||
| DataTypes.FIELD("f0", DataTypes.INT()), | ||
| DataTypes.FIELD("f0", DataTypes.INT().notNull()), |
There was a problem hiding this comment.
This hits the previous fix in
| // nullable and the cast does not allow setting the outer | ||
| // nullability but derives it from the source operand | ||
| DataTypes.of("ROW<r ROW<s STRING, b BOOLEAN, i INT>, s STRING>")), | ||
| // For nested rows we keep the nullability property. |
| @@ -93,16 +93,18 @@ Stream<TestSetSpec> getTestSetSpecs() { | |||
| FIELD( | |||
| "r", | |||
| ROW( | |||
| FIELD("s", STRING()), | |||
| FIELD( | |||
There was a problem hiding this comment.
I have fixed here to keep types in sql and types in table api equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When using cast, Flink uses
ExtendedSqlRowTypeNameSpecto derive the row type, and we should change theStructKindfromFULLY_QUALIFIEDin Calcite toPEEK_FIELDS_NO_EXPANDin Flink.Brief change log
Verifying this change
Some tests are added to verify this pr.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation